bump docker image version and fix related errors#2
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the container build baseline and CI/release automation to accommodate a newer base image and streamline image publishing.
Changes:
- Enable (and automerge) Renovate updates for
ghcr.io/sdr-enthusiasts/*Docker images. - Bump the Docker base image to
jlesage/baseimage-gui:debian-13-v4.11.3and update thelibqcustomplotruntime package name. - Switch the deploy workflow to use the shared
sdre.ymlreusable workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
renovate.json |
Enables Renovate docker updates for ghcr.io/sdr-enthusiasts/* images and automerge for those updates. |
Dockerfile |
Updates base image to Debian 13 variant and adjusts an OS package name for compatibility. |
.github/workflows/deploy.yml |
Migrates deploy job to the sdre.yml reusable workflow for building/pushing images. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "enabledManagers": ["nix", "github-actions", "dockerfile"], | ||
| "prConcurrentLimit": 0, | ||
| "prHourlyLimit": 0, | ||
| "prCreation": "immediate", | ||
| "automerge": true, | ||
| "platformAutomerge": true, | ||
| "nix": { | ||
| "enabled": true | ||
| }, | ||
| "packageRules": [ | ||
| { | ||
| "matchManagers": ["github-actions", "nix"], | ||
| "matchUpdateTypes": ["major", "minor", "patch", "pin"], | ||
| "automerge": true | ||
| }, | ||
| { | ||
| "matchDatasources": ["docker"], | ||
| "matchPackageNames": ["/^ghcr\\.io/sdr-enthusiasts/.*$/"], | ||
| "enabled": false | ||
| "enabled": true, | ||
| "automerge": true | ||
| } |
There was a problem hiding this comment.
This packageRule enables updates for ghcr.io/sdr-enthusiasts/* Docker images, but Renovate is currently limited to enabledManagers: ["nix", "github-actions", "dockerfile"]. Since the only matching reference in this repo is in docker-compose.yml, Renovate won't apply this rule unless the docker-compose manager is enabled (or the match is intended for Dockerfiles instead). Consider adding docker-compose to enabledManagers (or scoping this rule via matchManagers) so the rule actually affects the intended files.
No description provided.